<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - AX: Build with isolated tree enable is broken since r284075"
   href="https://bugs.webkit.org/show_bug.cgi?id=231667#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - AX: Build with isolated tree enable is broken since r284075"
   href="https://bugs.webkit.org/show_bug.cgi?id=231667">bug 231667</a>
              from <span class="vcard"><a class="email" href="mailto:andresg_22@apple.com" title="Andres Gonzalez <andresg_22@apple.com>"> <span class="fn">Andres Gonzalez</span></a>
</span></b>
        <pre>(In reply to Carlos Garcia Campos from <a href="show_bug.cgi?id=231667#c2">comment #2</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=441054&action=diff" name="attach_441054" title="Patch">attachment 441054</a> <a href="attachment.cgi?id=441054&action=edit" title="Patch">[details]</a></span>
> Patch</span >

--- a/Source/WebCore/accessibility/AccessibilityObject.cpp
+++ a/Source/WebCore/accessibility/AccessibilityObject.cpp

-uint64_t AccessibilityObject::sessionID() const
+PAL::SessionID AccessibilityObject::sessionID() const
 {
...
-    return 0;
+    return PAL::SessionID(PAL::SessionID::SessionConstants::HashTableEmptyValueID);
 }

Can we do return { }; instead?

--- a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
+++ a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
@@ -34,6 +34,7 @@
 #include "TextIteratorBehavior.h"
 #include "VisibleSelection.h"
 #include "Widget.h"
+#include <pal/SessionID.h>

Can we do a forward declaration of SessionID instead of a full include here? Since this file is included quite a bit, this may have a build time impact. There is some ongoing work to improve build time and it seems that forward declaring things help.

--- a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
+++ a/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

-uint64_t AXIsolatedObject::sessionID() const
+PAL::SessionID AXIsolatedObject::sessionID() const
 {
...
+    return PAL::SessionID(PAL::SessionID::SessionConstants::HashTableEmptyValueID);
 }

Can we do return { }; instead?

+PAL::SessionID AXIsolatedObject::sessionIDAttributeValue(AXPropertyName propertyName) const
+{
...
+        [] (auto&) { return PAL::SessionID(PAL::SessionID::SessionConstants::HashTableEmptyValueID); }
+    );
+}

Same as above.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>