<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Build with isolated tree enable is broken since r284075"
href="https://bugs.webkit.org/show_bug.cgi?id=231667">231667</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>AX: Build with isolated tree enable is broken since r284075
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Accessibility
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>cgarcia@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>achristensen@apple.com, andresg_22@apple.com, cdumez@apple.com, webkit-bug-importer@group.apple.com
</td>
</tr></table>
<p>
<div>
<pre>It happens at least with GCC:
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:8:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: In member function ‘void WebCore::AXIsolatedObject::initializeAttributeData(WebCore::AXCoreObject&, bool)’:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:415:64: error: cannot convert ‘uint64_t’ {aka ‘long unsigned int’} to ‘WebCore::AXPropertyValueVariant&&’ {aka ‘std::variant<std::nullptr_t, WTF::String, bool, int, unsigned int, double, float, long unsigned int, WebCore::Color, WTF::URL, WebCore::LayoutRect, WebCore::FloatRect, long unsigned int, WebCore::IntPoint, WTF::OptionSet<WebCore::SpeakAs>, std::pair<unsigned int, unsigned int>, WTF::Vector<WebCore::AccessibilityText, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<long unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<std::pair<long unsigned int, long unsigned int>, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WebCore::Path>&&’}
415 | setProperty(AXPropertyName::SessionID, object.sessionID());
| ~~~~~~~~~~~~~~~~^~
| |
| uint64_t {aka long unsigned int}
In file included from ../../Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp:24,
from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:6:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:77:38: note: initializing argument 2 of ‘void WebCore::AXIsolatedObject::setProperty(WebCore::AXPropertyName, WebCore::AXPropertyValueVariant&&, bool)’
77 | void setProperty(AXPropertyName, AXPropertyValueVariant&&, bool shouldRemove = false);
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:8:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: In member function ‘void WebCore::AXIsolatedObject::setObjectProperty(WebCore::AXPropertyName, WebCore::AXCoreObject*)’:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:469:51: error: cannot convert ‘WebCore::AXID’ {aka ‘long unsigned int’} to ‘WebCore::AXPropertyValueVariant&&’ {aka ‘std::variant<std::nullptr_t, WTF::String, bool, int, unsigned int, double, float, long unsigned int, WebCore::Color, WTF::URL, WebCore::LayoutRect, WebCore::FloatRect, long unsigned int, WebCore::IntPoint, WTF::OptionSet<WebCore::SpeakAs>, std::pair<unsigned int, unsigned int>, WTF::Vector<WebCore::AccessibilityText, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<long unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<std::pair<long unsigned int, long unsigned int>, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WebCore::Path>&&’}
469 | setProperty(propertyName, object->objectID());
| ~~~~~~~~~~~~~~~~^~
| |
| WebCore::AXID {aka long unsigned int}
In file included from ../../Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp:24,
from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-7.cpp:6:
../../Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:77:38: note: initializing argument 2 of ‘void WebCore::AXIsolatedObject::setProperty(WebCore::AXPropertyName, WebCore::AXPropertyValueVariant&&, bool)’
77 | void setProperty(AXPropertyName, AXPropertyValueVariant&&, bool shouldRemove = false);
| ^~~~~~~~~~~~~~~~~~~~~~~~
The problem seems to be that AXPropertyValueVariant contains the same type twice (in 64 bit systems) AXID (size_t -> long unsigned int) and uint64_t -> long unsigned int. That's actuallt allowed but makes the access ambiguous. Since uint64_t is only used for SessionID, I think we can explicitly use SessionID instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>