<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Implement parsing support for offset-distance, offset-position, offset-anchor"
   href="https://bugs.webkit.org/show_bug.cgi?id=231491">bug 231491</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #440736 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Implement parsing support for offset-distance, offset-position, offset-anchor"
   href="https://bugs.webkit.org/show_bug.cgi?id=231491#c5">Comment # 5</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Implement parsing support for offset-distance, offset-position, offset-anchor"
   href="https://bugs.webkit.org/show_bug.cgi?id=231491">bug 231491</a>
              from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=440736&action=diff" name="attach_440736" title="Patch">attachment 440736</a> <a href="attachment.cgi?id=440736&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=440736&action=review">https://bugs.webkit.org/attachment.cgi?id=440736&action=review</a>

Looks like you need to rebase more tests.

<span class="quote">> Source/WebCore/ChangeLog:8
> +        No new tests; WPT parsing tests are sufficient.</span >

If bits of this patch are from external contributors, you should acknowledge them here.

<span class="quote">> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3180
> +        case CSSPropertyObjectPosition:
> +            return valueForPosition(style, style.objectPosition());
> +        case CSSPropertyOffsetDistance:
> +            return cssValuePool.createValue(style.offsetDistance(), style);
> +        case CSSPropertyOffsetPosition:
> +            return valueForPositionOrAuto(style, style.offsetPosition());
> +        case CSSPropertyOffsetAnchor:
> +            return valueForPositionOrAuto(style, style.offsetAnchor());</span >

You can also use your helper for CSSPropertyPerspectiveOrigin, maybe others.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>