<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Move CSS longhand and shorthand mapping away from WI.CSSCompletions"
href="https://bugs.webkit.org/show_bug.cgi?id=231432">231432</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Web Inspector: Move CSS longhand and shorthand mapping away from WI.CSSCompletions
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Web Inspector
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>rcaliman@apple.com
</td>
</tr>
<tr>
<th>CC</th>
<td>inspector-bugzilla-changes@group.apple.com
</td>
</tr></table>
<p>
<div>
<pre>`WI.CSSCompletions` has scope creep. Beyond handling filtering for CSS completions, it holds logic to deal with CSS property name longhand-to-shorthand mapping and checks.
But `WI.CSSCompletions` already relies heavily on metadata about properties set on `WI.CSSKeywordCompletions`.
Moreover, the one-time initialization from `WI.CSSCompletions.initializeCSSCompletions(target)` > `WI.CSSKeywordCompletions.addCustomCompletions(properties)` already puts most of the metadata about CSS properties on:
- `WI.CSSKeywordCompletions.LonghandNamesForShorthandProperty`
- `WI.CSSKeywordCompletions.PropertyNameForAlias`
- `WI.CSSKeywordCompletions.InheritedProperties`
It makes sense to also move the longhand-to-shorthand mapping from `WI.CSSCompletions` to `WI.CSSKeywordCompletions`.
This keep mapping and checks co-located.
This is prep work for gradually removing `WI.CSSCompletions.cssNameCompletions` as a needlessly specialized completions manager.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>