<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - AX: Move handling of AXContents from platform wrapper to AX core"
   href="https://bugs.webkit.org/show_bug.cgi?id=231231#c5">Comment # 5</a>
              on <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - AX: Move handling of AXContents from platform wrapper to AX core"
   href="https://bugs.webkit.org/show_bug.cgi?id=231231">bug 231231</a>
              from <span class="vcard"><a class="email" href="mailto:andresg_22@apple.com" title="Andres Gonzalez <andresg_22@apple.com>"> <span class="fn">Andres Gonzalez</span></a>
</span></b>
        <pre>(In reply to Tyler Wilcock from <a href="show_bug.cgi?id=231231#c2">comment #2</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=440266&action=diff" name="attach_440266" title="Patch">attachment 440266</a> <a href="attachment.cgi?id=440266&action=edit" title="Patch">[details]</a></span>
> Patch</span >

--- a/Source/WebCore/accessibility/AccessibilityObjectInterface.h
+++ a/Source/WebCore/accessibility/AccessibilityObjectInterface.h

+    virtual void contents(AccessibilityChildrenVector&) = 0;

Should be 

virtual AccessibilityChildrenVector contents() = 0;

No need to pass an out parameter. Out parameters are bad and make client code less clear unnecessarily.

Also, can we make this method const:

virtual AccessibilityChildrenVector contents() const = 0;

or some of the function calls in the implementation cannot be const.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>