<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [JSC] Implement Temporal.Instant"
   href="https://bugs.webkit.org/show_bug.cgi?id=229826#c17">Comment # 17</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [JSC] Implement Temporal.Instant"
   href="https://bugs.webkit.org/show_bug.cgi?id=229826">bug 229826</a>
              from <span class="vcard"><a class="email" href="mailto:ysuzuki@apple.com" title="Yusuke Suzuki <ysuzuki@apple.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=439756&action=diff" name="attach_439756" title="Patch for preliminary review">attachment 439756</a> <a href="attachment.cgi?id=439756&action=edit" title="Patch for preliminary review">[details]</a></span>
Patch for preliminary review

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=439756&action=review">https://bugs.webkit.org/attachment.cgi?id=439756&action=review</a>

Added some more style nits.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalDuration.cpp:170
> +const ISO8601::Duration TemporalDuration::toLimitedDuration(JSGlobalObject* globalObject, JSValue itemValue, std::initializer_list<TemporalUnit> disallowedUnits)</span >

This const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalDuration.h:49
> +    static const ISO8601::Duration toLimitedDuration(JSGlobalObject*, JSValue, std::initializer_list<TemporalUnit> disallowedUnits);</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.cpp:48
> +TemporalInstant::TemporalInstant(VM& vm, Structure* structure, const ISO8601::ExactTime exactTime)</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.cpp:60
> +TemporalInstant* TemporalInstant::create(VM& vm, Structure* structure, const ISO8601::ExactTime exactTime)</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.cpp:70
> +TemporalInstant* TemporalInstant::tryCreateIfValid(JSGlobalObject* globalObject, const ISO8601::ExactTime exactTime, Structure* structure)</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.cpp:246
> +const ISO8601::Duration TemporalInstant::difference(JSGlobalObject* globalObject, TemporalInstant* other, JSValue optionsValue) const</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.cpp:308
> +const ISO8601::ExactTime TemporalInstant::round(JSGlobalObject* globalObject, JSValue optionsValue) const</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.cpp:385
> +String TemporalInstant::toString(const ISO8601::ExactTime exactTime, JSObject* timeZone, PrecisionData precision)</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.h:46
> +    static TemporalInstant* create(VM&, Structure*, const ISO8601::ExactTime);</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.h:47
> +    static TemporalInstant* tryCreateIfValid(JSGlobalObject*, const ISO8601::ExactTime, Structure* = nullptr);</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.h:61
> +    constexpr const ISO8601::ExactTime exactTime() const { return m_exactTime; }</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.h:64
> +    const ISO8601::Duration difference(JSGlobalObject*, TemporalInstant*, JSValue options) const;
> +    const ISO8601::ExactTime round(JSGlobalObject*, JSValue options) const;</span >

const iISO8601::XXX's const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.h:72
> +    TemporalInstant(VM&, Structure*, const ISO8601::ExactTime);</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.h:77
> +    static const ISO8601::ExactTime fromObject(JSGlobalObject*, JSObject*);</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstant.h:79
> +    static String toString(const ISO8601::ExactTime, JSObject* timeZone, PrecisionData);</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstantPrototype.cpp:118
> +    const ISO8601::Duration duration = TemporalDuration::toLimitedDuration(globalObject, callFrame->argument(0), disallowedAdditionUnits);</span >

const is not necessary.

<span class="quote">> Source/JavaScriptCore/runtime/TemporalInstantPrototype.cpp:139
> +    const ISO8601::Duration duration = TemporalDuration::toLimitedDuration(globalObject, callFrame->argument(0), disallowedAdditionUnits);</span >

const is not necessary.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>