<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Elements cloned into an iframe cannot be accessed by webdriver"
   href="https://bugs.webkit.org/show_bug.cgi?id=228270#c16">Comment # 16</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Elements cloned into an iframe cannot be accessed by webdriver"
   href="https://bugs.webkit.org/show_bug.cgi?id=228270">bug 228270</a>
              from <span class="vcard"><a class="email" href="mailto:drousso@apple.com" title="Devin Rousso <drousso@apple.com>"> <span class="fn">Devin Rousso</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=434888&action=diff" name="attach_434888" title="Patch">attachment 434888</a> <a href="attachment.cgi?id=434888&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=434888&action=review">https://bugs.webkit.org/attachment.cgi?id=434888&action=review</a>

<span class="quote">> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:33
> +var NodeType = {</span >

Style: `const`?

<span class="quote">> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:34
> +    ELEMENT: 1,</span >

Style: Is there a reason to uppercase these?  We normally CamelCase enums.

<span class="quote">> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:36
> +    DOCUMENT_FRAGMENT_NODE: 11</span >

Style: missing trailing comma

<span class="quote">> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:37
> +  };</span >

Style: odd indentation

<span class="quote">> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:207
> +    _isElement(value) {</span >

Style: `{` on it's own line

<span class="quote">> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:212
> +        return ((typeof value == 'object' && value != null) ||</span >

Style: please use `===` and `!==` unless you have a really good reason not to
Style: we prefer `"`
Style: can we split this into separate `if` or something?  Maybe use some early-returns and separate each line out so it's easier to read?</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>