<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - RenderListMarker::imageChanged RenderBox image handling"
   href="https://bugs.webkit.org/show_bug.cgi?id=230431">bug 230431</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>darin@apple.com
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Attachment #438528 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - RenderListMarker::imageChanged RenderBox image handling"
   href="https://bugs.webkit.org/show_bug.cgi?id=230431#c2">Comment # 2</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - RenderListMarker::imageChanged RenderBox image handling"
   href="https://bugs.webkit.org/show_bug.cgi?id=230431">bug 230431</a>
              from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=438528&action=diff" name="attach_438528" title="Patch">attachment 438528</a> <a href="attachment.cgi?id=438528&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=438528&action=review">https://bugs.webkit.org/attachment.cgi?id=438528&action=review</a>

<span class="quote">> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).</span >

Why no tests? Seems like we can and should make a test for whatever problem this caused.

<span class="quote">> Source/WebCore/rendering/RenderListMarker.cpp:1803
> +    if (m_image) {
> +        if (o == m_image->data()) {</span >

Let’s not nest this so much:

    if (m_image && o == m_image->data()) {
        ...</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>