<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:ysuzuki@apple.com" title="Yusuke Suzuki <ysuzuki@apple.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Fix CellTag being set 32 bits even if the base is not a cell"
   href="https://bugs.webkit.org/show_bug.cgi?id=230364">bug 230364</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>ysuzuki@apple.com
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Attachment #438404 Flags</td>
           <td>review?
           </td>
           <td>review-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Fix CellTag being set 32 bits even if the base is not a cell"
   href="https://bugs.webkit.org/show_bug.cgi?id=230364#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Fix CellTag being set 32 bits even if the base is not a cell"
   href="https://bugs.webkit.org/show_bug.cgi?id=230364">bug 230364</a>
              from <span class="vcard"><a class="email" href="mailto:ysuzuki@apple.com" title="Yusuke Suzuki <ysuzuki@apple.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=438404&action=diff" name="attach_438404" title="Patch">attachment 438404</a> <a href="attachment.cgi?id=438404&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=438404&action=review">https://bugs.webkit.org/attachment.cgi?id=438404&action=review</a>

Commented.

<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:13711
> +    JSValueRegs baseRegs;
> +    if (isCell(baseEdge.useKind())) {
> +        SpeculateCellOperand base(this, baseEdge);
> +        baseRegs = JSValueRegs::payloadOnly(base.gpr());
> +    } else {
> +        JSValueOperand base(this, baseEdge);
> +        baseRegs = base.regs();
> +    }</span >

This is not correct. When SpeculateCellOperand / JSValueOperand are destroyed, its tied register is unlocked.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>