<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Make PDFs loaded via <embed> accessible"
href="https://bugs.webkit.org/show_bug.cgi?id=229556#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Make PDFs loaded via <embed> accessible"
href="https://bugs.webkit.org/show_bug.cgi?id=229556">bug 229556</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>(In reply to Tyler Wilcock from <a href="show_bug.cgi?id=229556#c22">comment #22</a>)
<span class="quote">> > Why we need to split this method into two?
> I split it into two so that we can handle hit tests of both NSPoint's and
> WebCore::IntPoints. The NSPoint hit test just converts the point to a
> WebCore::IntPoint and calls the IntPoint hit test method.
>
> We could probably work entirely in NSPoints, but I'm having issues with the
> usual NSPoint forward declaration not being sufficient in Widget.h, so I'm
> inclined to leave it as-is unless you have a suggestion here.
>
> /Users/twilco/projects/web/OpenSource/Source/WebCore/platform/Widget.h:180:
> 44: error: variable has incomplete type 'NSPoint' (aka '_NSPoint')
> virtual id accessibilityHitTest(NSPoint) const { return nil; }
>
> /Users/twilco/projects/web/OpenSource/Source/WebCore/platform/graphics/
> IntPoint.h:40:16: note: forward declaration of '_NSPoint'
> typedef struct _NSPoint NSPoint;
>
> I tried #include <Foundation/NSGeometry.h>, but that causes more issues:
>
> error: expected unqualified-id @class NSString, Protocol;
>
> error: unknown type name 'NSString'
>
> And ~20 more similar errors.</span >
We can't use Foundation things inside WebCore code, only the wrappers</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>