<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Add functionalities for parsing URL query string"
   href="https://bugs.webkit.org/show_bug.cgi?id=228122#c40">Comment # 40</a>
              on <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Add functionalities for parsing URL query string"
   href="https://bugs.webkit.org/show_bug.cgi?id=228122">bug 228122</a>
              from <span class="vcard"><a class="email" href="mailto:wilander@apple.com" title="John Wilander <wilander@apple.com>"> <span class="fn">John Wilander</span></a>
</span></b>
        <pre>(In reply to Alex Christensen from <a href="show_bug.cgi?id=228122#c39">comment #39</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=434864&action=diff" name="attach_434864" title="Patch">attachment 434864</a> <a href="attachment.cgi?id=434864&action=edit" title="Patch">[details]</a></span>
> Patch

> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=434864&action=review">https://bugs.webkit.org/attachment.cgi?id=434864&action=review</a>

> Some post-commit feedback:

> > Source/WTF/wtf/URL.cpp:1225
> > +static StringView substringIgnoringQueryAndFragments(const URL& url)

> Could you move this to be a lambda inside isEqualIgnoringQueryAndFragments? 
> It's only used in that scope.

> > Source/WTF/wtf/URL.h:248
> > +WTF_EXPORT_PRIVATE bool isEqualIgnoringQueryAndFragments(const URL&, const URL&);

> I think this should either be renamed to areEqualIgnoringQueriesAndFragments
> or it should be made a member of the URL class.
> bool equalsIgnoringQueryAndFragment(const URL&) const;

> > Source/WTF/wtf/URL.h:249
> > +WTF_EXPORT_PRIVATE void removeQueryParameters(URL&, const HashSet<String>&);

> Could you add another important test case to verify that we don't regress
> behavior in the future?
> Make a URL from "<a href="https://example.com/?%C3%A4=value">https://example.com/?%C3%A4=value</a>"
> See how removing "%C3%A4" changes the URL.
> See how removing "รค" changes the URL.

> I think rather than passing a non-const URL as a parameter, this should be a
> member of the URL class.
> void removeQueryParametersWithKeys(const HashSet<String>& keys);</span >

Could you file follow-up Bugzillas, please? I can do it too if you're short on time. I just don't want us to lose these valuable enhancements.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>