<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:mcatanzaro@gnome.org" title="Michael Catanzaro <mcatanzaro@gnome.org>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Simplify TestWebKitAccessibility"
   href="https://bugs.webkit.org/show_bug.cgi?id=229032">bug 229032</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>mcatanzaro@gnome.org
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Attachment #435414 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Simplify TestWebKitAccessibility"
   href="https://bugs.webkit.org/show_bug.cgi?id=229032#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Simplify TestWebKitAccessibility"
   href="https://bugs.webkit.org/show_bug.cgi?id=229032">bug 229032</a>
              from <span class="vcard"><a class="email" href="mailto:mcatanzaro@gnome.org" title="Michael Catanzaro <mcatanzaro@gnome.org>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=435414&action=diff" name="attach_435414" title="Patch">attachment 435414</a> <a href="attachment.cgi?id=435414&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=435414&action=review">https://bugs.webkit.org/attachment.cgi?id=435414&action=review</a>

Heh, nice!

<span class="quote">> Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:41
> +        // We can get warnings from atspi when trying to connect to applications.
> +        Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
>          int childCount = atspi_accessible_get_child_count(desktop.get(), nullptr);
> +        Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);</span >

What sort of warnings?

Certainly not failing the test is good to do, but they probably pollute the test log, don't they?</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>