<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine."
   href="https://bugs.webkit.org/show_bug.cgi?id=199845#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine."
   href="https://bugs.webkit.org/show_bug.cgi?id=199845">bug 199845</a>
              from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=374270&action=diff" name="attach_374270" title="Patch">attachment 374270</a> <a href="attachment.cgi?id=374270&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=374270&action=review">https://bugs.webkit.org/attachment.cgi?id=374270&action=review</a>

<span class="quote">> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970
> -    if (!lineCount || !m_renderer)</span >

NSNotFound is an apple thing, so this check needs to be in the Mac wrapper. also probably sufficient to check if it’s equals to nsnotfound. I think it’s already uint max so it won’t matter checking higher

<span class="quote">> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983
> +            || visiblePos.equals(savedVisiblePos))</span >

surprised the == operator doesn’t call .equals directly</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>