<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - AX: VoiceOver allows to interact with a disabled <select> element"
   href="https://bugs.webkit.org/show_bug.cgi?id=193878#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - AX: VoiceOver allows to interact with a disabled <select> element"
   href="https://bugs.webkit.org/show_bug.cgi?id=193878">bug 193878</a>
              from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=360261&action=diff" name="attach_360261" title="Patch">attachment 360261</a> <a href="attachment.cgi?id=360261&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=360261&action=review">https://bugs.webkit.org/attachment.cgi?id=360261&action=review</a>

<span class="quote">> Source/WebCore/accessibility/AccessibilityMenuList.cpp:48
> +    Element* element = this->element();</span >

auto element = this->element();
if (!element || element->isDsiabled())
   return false;

<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3160
> +    // Used by DRT to find an accessible node by its element id.</span >

comment is wrong

<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3161
> +    if ([attributeName isEqualToString:@"AXDRTCollaspedAttribute"])</span >

spelled wrong AXDRTCollaspedAttribute

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:9
> +  <select id="test1" disabled></span >

no indent on these controls

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:18
> +  <select id="test2" disabled aria-disabled="true"></span >

can you add a test for disabled and aria-disabled='false"

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:34
> +    //Dont have tests for 'enabled' controls because when menu list opens a popup, it hangs on LayoutTests.</span >

// We don't test for enabled controls because opening menu lists waits on the UI process to display the menu.

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:39
> +      jsTestIsAsync = true;</span >

make sure indentation is 4 spaces every where

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:44
> +        pressNext();</span >

can you verify that collapsed is false before you start

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:48
> +      }, 10);</span >

do we need to wait 10 or can we just do it after 0

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:52
> +    {</span >

make sure { on previous line

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:65
> +        }, 20);</span >

do we need to wait 20?

<span class="quote">> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:81
> +        }, 20);</span >

do we need to wait 20?</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>