<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Import css-lists testcases from web platform tests"
   href="https://bugs.webkit.org/show_bug.cgi?id=193273#c22">Comment # 22</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Import css-lists testcases from web platform tests"
   href="https://bugs.webkit.org/show_bug.cgi?id=193273">bug 193273</a>
              from <span class="vcard"><a class="email" href="mailto:fred.wang@free.fr" title="Frédéric Wang (:fredw) <fred.wang@free.fr>"> <span class="fn">Frédéric Wang (:fredw)</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=358775&action=diff" name="attach_358775" title="Patch">attachment 358775</a> <a href="attachment.cgi?id=358775&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=358775&action=review">https://bugs.webkit.org/attachment.cgi?id=358775&action=review</a>

<span class="quote">> LayoutTests/ChangeLog:6
> +        Reviewed by  Daniel Bates.</span >

nit: there should be only one space between "by" and "Daniel"

<span class="quote">> LayoutTests/ChangeLog:10
> +        * platform/ios-simulator-wk2/TestExpectations:</span >

I wonder if we actually want ios-simulator-wk2 rather than ios-simulator but I guess that's ok for now ; someone will rebaseline the tests if necessary.

<span class="quote">> LayoutTests/platform/gtk/TestExpectations:3660
> +# css-lists reftests that are failing</span >

thinking again, maybe you can just remove this comment as it does not bring anything new (sorry for my previous suggestion)

<span class="quote">> LayoutTests/platform/ios-simulator-wk2/TestExpectations:48
> +# css-lists reftests that are failing</span >

lower-greek passes so I guess you can just remove this comment.

<span class="quote">> LayoutTests/platform/ios-simulator-wk2/TestExpectations:52
> +imported/w3c/web-platform-tests/css/css-lists/list-and-writing-mode-001.html [ Failure ]</span >

The diff we get from <a href="show_bug.cgi?id=193273#c20">comment 20</a> is just

-FAIL list and writing-mode assert_equals: the height of li should be 45px, and no extra line generated expected 45 but got 63
+FAIL list and writing-mode assert_equals: the height of li should be 45px, and no extra line generated expected 45 but got 65

so I would just add a specific list-and-writing-mode-001-expected.txt file for this platform.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>