<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>"
   href="https://bugs.webkit.org/show_bug.cgi?id=193056">193056</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>WebKit
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>WebKit Local Build
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P2
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Web Template Framework
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>webkit-unassigned@lists.webkit.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>ddkilzer@webkit.org
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>andersca@apple.com, darin@apple.com, dbates@webkit.org, mitz@webkit.org, mjs@apple.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Prefer RetainPtr<NSObject> to RetainPtr<NSObject *> because:
- It was the original intent based on Macieij's comment from r16987.
- The vast majority of RetainPtr<> use in WebKit already omits the '*' operator for NS types.  (Yay consistency!)
- We can write a style checker rule to enforce it.
- We can make adoptNS() and retainPtr() create the correct types using C++ template metaprogramming.

Note that RetainPtr<NSObject *> still works as it did before (and tests have been added to verify that it works with RetainPtr<NSObject>).

This change simply formalizes the preference for RetainPtr<NSObject> over RetainPtr<NSObject *>.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>