<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_UNCONFIRMED "
   title="UNCONFIRMED - [FreeType] Color emoji not properly supported"
   href="https://bugs.webkit.org/show_bug.cgi?id=191976">bug 191976</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #357679 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_UNCONFIRMED "
   title="UNCONFIRMED - [FreeType] Color emoji not properly supported"
   href="https://bugs.webkit.org/show_bug.cgi?id=191976#c15">Comment # 15</a>
              on <a class="bz_bug_link 
          bz_status_UNCONFIRMED "
   title="UNCONFIRMED - [FreeType] Color emoji not properly supported"
   href="https://bugs.webkit.org/show_bug.cgi?id=191976">bug 191976</a>
              from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=357679&action=diff" name="attach_357679" title="Patch">attachment 357679</a> <a href="attachment.cgi?id=357679&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=357679&action=review">https://bugs.webkit.org/attachment.cgi?id=357679&action=review</a>

Myles might want to review the cross-platform changes after the holidays, but they look relatively straightforward so I don't think we need to delay.

<span class="quote">> Source/WTF/wtf/unicode/CharacterNames.h:103
> +const UChar combiningEnclosingKeycap = 0x20E3;</span >

This should be alphabetized, like the rest of the list.

<span class="quote">> Source/WTF/wtf/unicode/CharacterNames.h:170
> +using WTF::Unicode::combiningEnclosingKeycap;</span >

Ditto.

<span class="quote">>> Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:67
>> +        if (nextCharacter == 0xFE0F) {

> Maybe it would be good to give a name to this constant instead of leaving
> magic numbers around in the middle of the function.</span >

I think it's fine; it's not used anywhere else, and there's a comment to explain it.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>