<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened"
   href="https://bugs.webkit.org/show_bug.cgi?id=192375#c30">Comment # 30</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened"
   href="https://bugs.webkit.org/show_bug.cgi?id=192375">bug 192375</a>
              from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
        <pre>(In reply to Alex Christensen from <a href="show_bug.cgi?id=192375#c29">comment #29</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=356978&action=diff" name="attach_356978" title="Patch">attachment 356978</a> <a href="attachment.cgi?id=356978&action=edit" title="Patch">[details]</a></span>
> Patch

> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=356978&action=review">https://bugs.webkit.org/attachment.cgi?id=356978&action=review</a>

> > Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:209
> > +    if (m_requestLoadType != LoadType::MainFrame)
> > +        return;

> Why don't we want to upgrade sub resource requests?</span >

This has been discussed, we have no guarantee that this would work. Only main frame URLs were tested.

<span class="quote">> 
> > Source/WebKit/NetworkProcess/NetworkLoadChecker.h:64
> > +    void check(WebCore::ResourceRequest&&, WebCore::ContentSecurityPolicyClient*, ValidationHandler&&);

> This is a bad name.</span ></pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>