<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Implement the Web Share API"
   href="https://bugs.webkit.org/show_bug.cgi?id=171100#c49">Comment # 49</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Implement the Web Share API"
   href="https://bugs.webkit.org/show_bug.cgi?id=171100">bug 171100</a>
              from <span class="vcard"><a class="email" href="mailto:obarnett@apple.com" title="Olivia Barnett <obarnett@apple.com>"> <span class="fn">Olivia Barnett</span></a>
</span></b>
        <pre>(In reply to Wenson Hsieh from <a href="show_bug.cgi?id=171100#c48">comment #48</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=348225&action=diff" name="attach_348225" title="Patch">attachment 348225</a> <a href="attachment.cgi?id=348225&action=edit" title="Patch">[details]</a></span>
> Patch

> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=348225&action=review">https://bugs.webkit.org/attachment.cgi?id=348225&action=review</a>

> > Source/WebCore/ChangeLog:9
> > +        No new tests; adjusted expectations for existing tests.

> You should mention your new test in fast/events/ios!

> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:384
> > +- (void)invokeShareSheetWithResolution:(BOOL)resolved WK_API_AVAILABLE(ios(11.3));

> This should be WK_API_AVAILABLE(ios(WK_IOS_TBA));

> > Source/WebKit/UIProcess/PageClient.h:205
> > +    virtual bool showShareSheet(WebPageProxy*, const WebCore::ShareDataWithParsedURL&,  WTF::CompletionHandler<void (bool)>&&) { return false; }

> Nit - extra space before WTF::

> > Source/WebKit/UIProcess/WebPageProxy.cpp:5254
> > +    

> Nit - it doesn't look like this extra whitespace change is intended

> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.h:46
> > +@property (nonatomic, weak, assign) id <WKShareSheetDelegate> delegate;

> Nit - I don't think you need the assign here.

> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:40
> > +@interface _WKShareSheetItem : NSObject

> Hm...what's _WKShareSheetItem used for?</span >

Ah, nothing.
<span class="quote">> 
> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:80
> > +    RetainPtr<UIActivityViewController> shareSheetController = adoptNS([[UIActivityViewController alloc] initWithActivityItems:shareDataArray.get() applicationActivities:nil]);

> Nit - s/RetainPtr<UIActivityViewController>/auto/

> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:88
> > +    _shareSheetViewController = shareSheetController;

> This can be _shareSheetViewController = WTFMove(shareSheetController);

> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:6085
> > +void WebPage::runShareSheetResponse(bool wasGranted, uint64_t callbackID)

> s/uint64_t/ShareSheetCallbackID/ here?

> > Source/WebKit/WebProcess/WebPage/WebPage.h:1734
> > +    HashMap<uint64_t, WTF::Function<void(bool completed)>> m_shareSheetResponseCallbackMap;

> ShareSheetCallbackID here too?

> > LayoutTests/fast/events/ios/share.html:20
> > +                    navigator.share({ title: "Example Page", url: "url", text: "text"}).then((result) => {

> Nit - Indentation is a bit off here too.

> Also, a space between "text" and }

> > LayoutTests/resources/ui-helper.js:248
> > +     const resolveShareSheet = `(() => uiController.invokeShareSheetWithResolution(${resolved}))()`;

> Nit - Indentation is a bit off here.</span ></pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>