<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Remove dead exception in MediaList.appendMedium"
   href="https://bugs.webkit.org/show_bug.cgi?id=185278">bug 185278</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>cdumez@apple.com
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Attachment #339557 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Remove dead exception in MediaList.appendMedium"
   href="https://bugs.webkit.org/show_bug.cgi?id=185278#c12">Comment # 12</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Remove dead exception in MediaList.appendMedium"
   href="https://bugs.webkit.org/show_bug.cgi?id=185278">bug 185278</a>
              from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=339557&action=diff" name="attach_339557" title="Add back GError parameter">attachment 339557</a> <a href="attachment.cgi?id=339557&action=edit" title="Add back GError parameter">[details]</a></span>
Add back GError parameter

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=339557&action=review">https://bugs.webkit.org/attachment.cgi?id=339557&action=review</a>

r=me with nit.

<span class="quote">> Source/WebCore/css/MediaList.cpp:211
> +    bool added = m_mediaQueries->add(medium);</span >

I do not think we need this local. Could be:
if (!m_mediaQueries->add(medium))
    return;</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>