<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - AX: AOM: respect the accessibility setting for dispatching the accessible events"
   href="https://bugs.webkit.org/show_bug.cgi?id=184619#c29">Comment # 29</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - AX: AOM: respect the accessibility setting for dispatching the accessible events"
   href="https://bugs.webkit.org/show_bug.cgi?id=184619">bug 184619</a>
              from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=338165&action=diff" name="attach_338165" title="patch">attachment 338165</a> <a href="attachment.cgi?id=338165&action=edit" title="patch">[details]</a></span>
patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=338165&action=review">https://bugs.webkit.org/attachment.cgi?id=338165&action=review</a>

<span class="quote">> Source/WTF/wtf/Platform.h:1333
> +#define HAVE_ACCESSIBILITY_EVENTS 1</span >

I think we should have ENABLE flag instead.

<span class="quote">> Source/WebCore/page/Settings.yaml:735
> +  initial: true</span >

This should be conditional to the build flag. It's weird to have an on-by-default flag which doesn't do anything loser OS

<span class="quote">> Source/WebCore/testing/Internals.cpp:270
> +void _AXSSetWebAccessibilityEventsEnabled(Boolean);</span >

Does this feature enable it for this web content process, or is it system wide?
We can't mutate a global system state because we run tests concurrency.

Also, this should be done via internals.settings instead of any.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>