<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo] Add WKView and WKAPI for wincairo"
   href="https://bugs.webkit.org/show_bug.cgi?id=182869">bug 182869</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #335295 Flags</td>
           <td>review?
           </td>
           <td>review-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo] Add WKView and WKAPI for wincairo"
   href="https://bugs.webkit.org/show_bug.cgi?id=182869#c7">Comment # 7</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo] Add WKView and WKAPI for wincairo"
   href="https://bugs.webkit.org/show_bug.cgi?id=182869">bug 182869</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=335295&action=diff" name="attach_335295" title="Patch">attachment 335295</a> <a href="attachment.cgi?id=335295&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=335295&action=review">https://bugs.webkit.org/attachment.cgi?id=335295&action=review</a>

This is adding a file that doesn't compile.  Let's not.

<span class="quote">> Source/WebKit/UIProcess/API/C/win/WKAPICastWin.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.</span >

If this is resurrecting old code, please indicate the initial commit this came from.

<span class="quote">> Source/WebKit/UIProcess/API/C/win/WKAPICastWin.h:38
> +WK_ADD_API_MAPPING(WKViewRef, WebView)</span >

Is WebView correct?  I think we might want something more like WebPageProxy here.

<span class="quote">> Source/WebKit/UIProcess/API/C/win/WKView.cpp:32
> +#include "WebView.h"</span >

WebView.h doesn't exist in modern WebKit.  Does this compile?</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>