<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html fails with async policy delegate"
   href="https://bugs.webkit.org/show_bug.cgi?id=183386">bug 183386</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #335646 is obsolete</td>
           <td>1
           </td>
           <td>
                
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html fails with async policy delegate"
   href="https://bugs.webkit.org/show_bug.cgi?id=183386#c12">Comment # 12</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html fails with async policy delegate"
   href="https://bugs.webkit.org/show_bug.cgi?id=183386">bug 183386</a>
              from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=335646&action=diff" name="attach_335646" title="Patch for review">attachment 335646</a> <a href="attachment.cgi?id=335646&action=edit" title="Patch for review">[details]</a></span>
Patch for review

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=335646&action=review">https://bugs.webkit.org/attachment.cgi?id=335646&action=review</a>

<span class="quote">> LayoutTests/ChangeLog:8
> +                          This test relies on the happenstance that with sync poicy decision, the subframe transitions</span >

Indentation issue. Please only use spaces, not tabs.

<span class="quote">> LayoutTests/ChangeLog:9
> +                          to FrameLoadProvisional before main frame navigation is committed.  With async delegate,</span >

Only 1 space after the '.'

<span class="quote">> LayoutTests/ChangeLog:15
> +        * http/tests/navigation/page-cache-iframe-provisional-load-async-delegates.html: Added.</span >

Please update existing test too. Otherwise, it will start failing when we enable async policy delegates by default.

Also, it will help me see what has changed :)

<span class="quote">> LayoutTests/ChangeLog:16
> +                          Add a new version of the test that forces the main frame navigation to start after the</span >

indentation issue.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>