<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [EME][GStreamer] Add support for the encrypted Caps in GStreamerUtilities"
   href="https://bugs.webkit.org/show_bug.cgi?id=181990">bug 181990</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #333381 Flags</td>
           <td>review?, commit-queue?
           </td>
           <td>review+, commit-queue-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [EME][GStreamer] Add support for the encrypted Caps in GStreamerUtilities"
   href="https://bugs.webkit.org/show_bug.cgi?id=181990#c15">Comment # 15</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [EME][GStreamer] Add support for the encrypted Caps in GStreamerUtilities"
   href="https://bugs.webkit.org/show_bug.cgi?id=181990">bug 181990</a>
              from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=333381&action=diff" name="attach_333381" title="Patch">attachment 333381</a> <a href="attachment.cgi?id=333381&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=333381&action=review">https://bugs.webkit.org/attachment.cgi?id=333381&action=review</a>

<span class="quote">> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:63
> +        GST_ERROR("Failed to get the video size and format, they are not a video caps");</span >

ERROR -> WARNING. caps is always plural so "these are not video caps".

<span class="quote">> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:75
> +            pixelAspectRatioNumerator = pixelAspectRatioDenominator = 1;</span >

This goes against coding style, one instruction at a line.

<span class="quote">> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:99
> +        GST_WARNING("Failed to get the video resolution, they are not a video caps");</span >

these are not video caps

<span class="quote">> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:100
> +        return std::optional<FloatSize>();</span >

You need to return std::nullopt here, otherwise asking for has_value will answer always yes.

<span class="quote">> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:123
> +    return std::optional<FloatSize>(FloatSize(width, height * (static_cast<float>(pixelAspectRatioNumerator) / static_cast<float>(pixelAspectRatioDenominator))));</span >

You can use std::make_optional</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>