<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning: comparison is always false due to limited range of data type [-Wtype-limits]"
   href="https://bugs.webkit.org/show_bug.cgi?id=178543">bug 178543</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>sbarati@apple.com
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning: comparison is always false due to limited range of data type [-Wtype-limits]"
   href="https://bugs.webkit.org/show_bug.cgi?id=178543#c1">Comment # 1</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning: comparison is always false due to limited range of data type [-Wtype-limits]"
   href="https://bugs.webkit.org/show_bug.cgi?id=178543">bug 178543</a>
              from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
        <pre>(In reply to Michael Catanzaro from <a href="show_bug.cgi?id=178543#c0">comment #0</a>)
<span class="quote">> r223691 "Turn recursive tail calls into loops" introduced the following
> warning when building WebKitGTK+ with GCC 7.2.1:

> ../../Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: In member function
> ‘bool JSC::DFG::ByteCodeParser::handleRecursiveTailCall(JSC::DFG::Node*,
> const JSC::CallLinkStatus&, int, JSC::VirtualRegister, int)’:
> ../../Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1483:83: warning:
> comparison is always false due to limited range of data type [-Wtype-limits]
>      } while (stackEntry->m_inlineCallFrame &&
> stackEntry->m_inlineCallFrame->kind == TailCall && (stackEntry =
> stackEntry->m_caller));
>                                               
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

> It's a bit surprising because InlineCallFrame::Kind has only eight possible
> values (including TailCall), and InlineCallFrame::kind is an unsigned
> bitfield three bits wide, which seems like it should be enough.</span >

Oh wow. This should be
stackEntry->m_inlineCallFrame->kind == InlineCallFrame::TailCall I think</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>