<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI"
   href="https://bugs.webkit.org/show_bug.cgi?id=174394#c57">Comment # 57</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI"
   href="https://bugs.webkit.org/show_bug.cgi?id=174394">bug 174394</a>
              from <span class="vcard"><a class="email" href="mailto:riedel@apple.com" title="Frederik Riedel <riedel@apple.com>"> <span class="fn">Frederik Riedel</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=321600&action=diff" name="attach_321600" title="Patch">attachment 321600</a> <a href="attachment.cgi?id=321600&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=321600&action=review">https://bugs.webkit.org/attachment.cgi?id=321600&action=review</a>

<span class="quote">>> Source/WebCore/editing/ios/AutofillElements.h:36
>> +    AutofillElements(RefPtr<HTMLInputElement>, RefPtr<HTMLInputElement>);

> Use RefPtr<HTMLInputElement>&& instead to avoid ref churn.</span >

What is 'ref churn'?

<span class="quote">>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2816
>> +        auto autofillElements = AutofillElements::computeAutofillElements(assistendElement.get());

> It looks like we don't need this local variable?
> Why not just do this?:
> AutofillElements::computeAutofillElements(downcast<HTMLInputElement>(*m_assistedNode));</span >

Done.

<span class="quote">>> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:37
>> +// FIXME 34583628: Simplyfy this once the UIKit work is available in the build.

> Nit: "FIXME <radar:34583628>: ~"</span >

Done.



Thanks for reviewing, Ryosuke!</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>