<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Network cache should be usable as non-singleton"
   href="https://bugs.webkit.org/show_bug.cgi?id=175139">bug 175139</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>sam@webkit.org
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Network cache should be usable as non-singleton"
   href="https://bugs.webkit.org/show_bug.cgi?id=175139#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Network cache should be usable as non-singleton"
   href="https://bugs.webkit.org/show_bug.cgi?id=175139">bug 175139</a>
              from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=317168&action=diff" name="attach_317168" title="patch">attachment 317168</a> <a href="attachment.cgi?id=317168&action=edit" title="patch">[details]</a></span>
patch

Nice! This also has the nice side effect that if we want to do targeted unit testing of it, it's much more straight forward.

One thing that might make things a little nicer, though could be left for later, is to make the NetworkProcess object, which is a singleton, own the NetworkCache instance, any make accessing the singleton be via NetworkProcess::singleton()->diskCache() (or whatever).  It would also make the calls to NetworkCache::Cache::open() that don't use their return values much less mysterious.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>