<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - WebDriver: fix return value of close window command"
   href="https://bugs.webkit.org/show_bug.cgi?id=174861">bug 174861</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #316445 Flags</td>
           <td>review?
           </td>
           <td>review-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - WebDriver: fix return value of close window command"
   href="https://bugs.webkit.org/show_bug.cgi?id=174861#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - WebDriver: fix return value of close window command"
   href="https://bugs.webkit.org/show_bug.cgi?id=174861">bug 174861</a>
              from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=316445&action=diff" name="attach_316445" title="Patch">attachment 316445</a> <a href="attachment.cgi?id=316445&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=316445&action=review">https://bugs.webkit.org/attachment.cgi?id=316445&action=review</a>

Absent a good justification, I don't want to add a redundant command. The web service parts look good.

<span class="quote">> Source/WebDriver/Session.cpp:308
> +void Session::continueGetWindowHandles(const InspectorObject& result, Function<void (CommandResult&&)>&& completionHandler)</span >

Nit: I prefer "fetchWindowHandles" or just "getWindowHandles".

<span class="quote">> Source/WebKit/UIProcess/Automation/Automation.json:250
> +            "returns": [</span >

I don't like this. It's redundant with another command. Can you just compose the two Automation commands in the service implementation? That's what safaridriver does.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>