<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Add performance.mark()s around Speedometer test steps"
   href="https://bugs.webkit.org/show_bug.cgi?id=174530#c2">Comment # 2</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Add performance.mark()s around Speedometer test steps"
   href="https://bugs.webkit.org/show_bug.cgi?id=174530">bug 174530</a>
              from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=315805&action=diff" name="attach_315805" title="Patch">attachment 315805</a> <a href="attachment.cgi?id=315805&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=315805&action=review">https://bugs.webkit.org/attachment.cgi?id=315805&action=review</a>

Thanks for the patch.

<span class="quote">> PerformanceTests/ChangeLog:8
> +        <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Add performance.mark()s around Speedometer test steps"
   href="show_bug.cgi?id=174530">https://bugs.webkit.org/show_bug.cgi?id=174530</a></span >

This URL should appear right below the it title.

<span class="quote">> PerformanceTests/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).</span >

Followed by this line, and then the long description you have above.
See other entries for the format.

<span class="quote">> PerformanceTests/Speedometer/resources/benchmark-runner.js:116
> +    if (window.performance && window.performance.mark) { window.performance.mark(name); }</span >

Please put the call to mark in a separate line with an indentation but without curly braces to match the WebKit coding style.

<span class="quote">> PerformanceTests/Speedometer/resources/benchmark-runner.js:252
> +        self._runTest(`${suite.name}.${test.name}`, suite, test.run, self._prepareReturnValue, function (syncTime, asyncTime) {</span >

I think it’s cleaner to pass in the test object, and construct the string in _runTrst function.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>