<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - WIP - RunBenchmark WebDriver testing"
   href="https://bugs.webkit.org/show_bug.cgi?id=174056#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - WIP - RunBenchmark WebDriver testing"
   href="https://bugs.webkit.org/show_bug.cgi?id=174056">bug 174056</a>
              from <span class="vcard"><a class="email" href="mailto:dewei_zhu@apple.com" title="dewei_zhu@apple.com">dewei_zhu</a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=314327&action=diff" name="attach_314327" title="Patch">attachment 314327</a> <a href="attachment.cgi?id=314327&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=314327&action=review">https://bugs.webkit.org/attachment.cgi?id=314327&action=review</a>

<span class="quote">> Tools/ChangeLog:7
> +</span >

A lot of files are duplicated. We should try to figure out a way to reuse the code from run-benchmark.

<span class="quote">> Tools/Scripts/webkitpy/webdriver_benchmark_runner/README.md:1
> +# Benchmark Runner </span >

Looks like this file need to be updated.

<span class="quote">> Tools/Scripts/webkitpy/webdriver_benchmark_runner/benchmark_runner.py:19
> +'''from selenium import webdriver
> +from selenium.webdriver.chrome.options import Options'''</span >

We should remove commented code.

<span class="quote">> Tools/Scripts/webkitpy/webdriver_benchmark_runner/browser_driver/linux_browser_driver.py:32
> +from selenium import webdriver</span >

Is this used?</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>