<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use window.internals instead of overridePreference to set WebCore settings in tests"
   href="https://bugs.webkit.org/show_bug.cgi?id=173714">bug 173714</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>joepeck@webkit.org
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use window.internals instead of overridePreference to set WebCore settings in tests"
   href="https://bugs.webkit.org/show_bug.cgi?id=173714#c10">Comment # 10</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use window.internals instead of overridePreference to set WebCore settings in tests"
   href="https://bugs.webkit.org/show_bug.cgi?id=173714">bug 173714</a>
              from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=313615&action=diff" name="attach_313615" title="Patch">attachment 313615</a> <a href="attachment.cgi?id=313615&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=313615&action=review">https://bugs.webkit.org/attachment.cgi?id=313615&action=review</a>

<span class="quote">> LayoutTests/ChangeLog:4
> +        Use window.internals instead of overridePreference to set WebCore settings in tests
> +        <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use window.internals instead of overridePreference to set WebCore settings in tests"
   href="show_bug.cgi?id=173714">https://bugs.webkit.org/show_bug.cgi?id=173714</a></span >

With this change you should be able to eliminate any no longer used settings from InjectedBundle::overrideBoolPreferenceForTestRunner.

<span class="quote">> LayoutTests/ChangeLog:7
> +</span >

We try to include a description of the change here in the ChangeLog if it is not immediately obvious from the title.

<span class="quote">> LayoutTests/accessibility/gtk/caret-browsing-select-focus.html:17
> +if (window.testRunner && window.internals) {
> +  internals.setEnableCaretBrowsing(true);</span >

I'm a bit confused by these changes. I don't think `internals.setEnableCaretBrowsing` exists. Perhaps `internals.settings.setEnableCaretBrowsing` does?

To clarify my earlier comment from:
<a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WK2][WTR] Implement overridePreference() for non-boolean values"
   href="show_bug.cgi?id=128594#c3">https://bugs.webkit.org/show_bug.cgi?id=128594#c3</a>

I think, where possible, we should move:

    testRunner.overridePreference("WebKitFooEnabled", true);

to:

    internals.settings.setFooEnabled(true)

Since using internals.settings is more direct, would fail immediately and obviously if its a function that does not exist, and these settings are restored properly between tests.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>