<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [Cocoa] implement URLSession:task:needNewBodyStream: delegate method"
   href="https://bugs.webkit.org/show_bug.cgi?id=173551#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [Cocoa] implement URLSession:task:needNewBodyStream: delegate method"
   href="https://bugs.webkit.org/show_bug.cgi?id=173551">bug 173551</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=313308&action=diff" name="attach_313308" title="Patch">attachment 313308</a> <a href="attachment.cgi?id=313308&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=313308&action=review">https://bugs.webkit.org/attachment.cgi?id=313308&action=review</a>

<span class="quote">>> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:154
>> +    auto* body = networkDataTask->firstRequest().httpBody();

> NSURLSessionTask has currentRequest</span >

Ah, we do want the http body of the first request, even if redirected.  This is an HTTP POST request.

<span class="quote">> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:160
> +    // FIXME: Is there a problem if some files are different in size since the original sizing?</span >

I think if someone modifies a file as we are uploading it they're going to have a bad time anyways.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>