<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor"
   href="https://bugs.webkit.org/show_bug.cgi?id=173355">bug 173355</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>darin@apple.com
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor"
   href="https://bugs.webkit.org/show_bug.cgi?id=173355#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor"
   href="https://bugs.webkit.org/show_bug.cgi?id=173355">bug 173355</a>
              from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=312869&action=diff" name="attach_312869" title="Patch">attachment 312869</a> <a href="attachment.cgi?id=312869&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=312869&action=review">https://bugs.webkit.org/attachment.cgi?id=312869&action=review</a>

<span class="quote">>> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:85
>> +    void didChangeSelection(WebPage&, StringImpl* /*notificationName*/) override

> Consider UNUSED_PARAM(notificationName), or just not listing the argument name.</span >

For what it’s worth, I consider commenting out the name to be better than UNUSED_PARAM. I see UNUSED_PARAM as a necessary evil that we try to avoid, since it doesn’t even work -- it silences the warning, but doesn’t prevent use of the thing it marks as "unused"! But maybe we don’t have consensus on that.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>