<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Do not mix C and C++ API error constants"
   href="https://bugs.webkit.org/show_bug.cgi?id=173311">bug 173311</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #312766 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Do not mix C and C++ API error constants"
   href="https://bugs.webkit.org/show_bug.cgi?id=173311#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Do not mix C and C++ API error constants"
   href="https://bugs.webkit.org/show_bug.cgi?id=173311">bug 173311</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=312766&action=diff" name="attach_312766" title="Patch">attachment 312766</a> <a href="attachment.cgi?id=312766&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=312766&action=review">https://bugs.webkit.org/attachment.cgi?id=312766&action=review</a>

<span class="quote">> Source/WebKit2/Shared/API/APIError.h:51
> +    enum General {</span >

We're trying to use more enum classes in WebKit unless there's a good reason not to.  And we need to be sure to have source and binary compatibility, which I think this patch has.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>