<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - navigator.webdriver should return false if the page is not controlled by automation"
   href="https://bugs.webkit.org/show_bug.cgi?id=171997">bug 171997</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #310918 Flags</td>
           <td>review?
           </td>
           <td>review-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - navigator.webdriver should return false if the page is not controlled by automation"
   href="https://bugs.webkit.org/show_bug.cgi?id=171997#c14">Comment # 14</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - navigator.webdriver should return false if the page is not controlled by automation"
   href="https://bugs.webkit.org/show_bug.cgi?id=171997">bug 171997</a>
              from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=310918&action=diff" name="attach_310918" title="Patch">attachment 310918</a> <a href="attachment.cgi?id=310918&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=310918&action=review">https://bugs.webkit.org/attachment.cgi?id=310918&action=review</a>

Patch looks good otherwise.

<span class="quote">> Source/WebCore/ChangeLog:5
> +        Per WebDriver Specification at <a href="https://www.w3.org/TR/webdriver/#interface">https://www.w3.org/TR/webdriver/#interface</a></span >

The description should come *after* the reviewed by line.

<span class="quote">> Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp:52
> +    Frame* frame = navigator.frame();</span >

auto*

<span class="quote">> Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp:53
> +    if (frame || !frame->page())</span >

This check seems wrong, should probably !frame.

<span class="quote">> LayoutTests/js/dom/navigator-webdriver.html:8
> +description(</span >

Just description("Check that navigator.webdriver has the right attributes.");

<span class="quote">> LayoutTests/js/dom/navigator-webdriver.html:12
> +if (window.testRunner) {</span >

We don't use curly brackets for one-liners.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>