<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling geolocation authorization requests"
href="https://bugs.webkit.org/show_bug.cgi?id=170362#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling geolocation authorization requests"
href="https://bugs.webkit.org/show_bug.cgi?id=170362">bug 170362</a>
from <span class="vcard"><a class="email" href="mailto:david_quesada@apple.com" title="David Quesada <david_quesada@apple.com>"> <span class="fn">David Quesada</span></a>
</span></b>
<pre>(In reply to Alex Christensen from <a href="show_bug.cgi?id=170362#c15">comment #15</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=306764&action=diff" name="attach_306764" title="Patch v2.1">attachment 306764</a> <a href="attachment.cgi?id=306764&action=edit" title="Patch v2.1">[details]</a></span>
> Patch v2.1
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=306764&action=review">https://bugs.webkit.org/attachment.cgi?id=306764&action=review</a>
>
> LGTM except the memory leak.
>
> > Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:92
> > + RetainPtr<id<_WKGeolocationCoreLocationProvider>> _coreLocationProvider;
>
> I'm not sure if the id is necessary here. If it is, we seem to have a space
> after id elsewhere in WebKit.</span >
The id is necessary since _WKGeolocationCoreLocationProvider is a protocol type, not a the name of a class, which would be usable without id<>.
<span class="quote">>
> > Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:269
> > + _provider = [[WebGeolocationCoreLocationProvider alloc] initWithListener:self];
>
> We need an adoptNS or this is a memory leak.</span >
Will fix.
<span class="quote">>
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm:42
> > +SOFT_LINK_FRAMEWORK(CoreLocation)
> > +SOFT_LINK_CLASS(CoreLocation, CLLocation)
>
> Is there a reason we're soft linking?</span >
The WebKit code that uses CoreLocation (WebGeolocationCoreLocationProvider) soft links it, so I also soft linked CoreLocation in the API tests. I'll change this to regular linking since there's not much of a point in soft linking in TestWebKitAPI.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>