<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling geolocation authorization requests"
href="https://bugs.webkit.org/show_bug.cgi?id=170362#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling geolocation authorization requests"
href="https://bugs.webkit.org/show_bug.cgi?id=170362">bug 170362</a>
from <span class="vcard"><a class="email" href="mailto:david_quesada@apple.com" title="David Quesada <david_quesada@apple.com>"> <span class="fn">David Quesada</span></a>
</span></b>
<pre>(In reply to Alex Christensen from <a href="show_bug.cgi?id=170362#c12">comment #12</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=306761&action=diff" name="attach_306761" title="Patch v2">attachment 306761</a> <a href="attachment.cgi?id=306761&action=edit" title="Patch v2">[details]</a></span>
> Patch v2
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=306761&action=review">https://bugs.webkit.org/attachment.cgi?id=306761&action=review</a>
>
> > Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:78
> > +static inline RefPtr<WebGeolocationPosition> kit(WebCore::GeolocationPosition *position)
>
> Let's make this return a Ref, and make WebGeolocationPosition::create return
> a Ref instead of a PassRefPtr. This will require dereferencing the newly
> allocated pointer, which we commonly do in WebKit.
> return adoptRef(*new WebGeolocationPosition ...</span >
Done.
<span class="quote">>
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm:28
> > +#if WK_API_ENABLED
>
> It looks like this API test will run on Mac, and I'm not sure what will
> happen if it does. Maybe we could make this test run on Mac, maybe we
> should make it just run on iOS.</span >
I'll make the tests only run on iOS. The new delegate method and the ability to swap out a location provider are only compiled on iOS, so it doesn't make sense to try to test them on Mac.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>