<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089">bug 170089</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #305523 Flags</td>
<td>commit-queue-
</td>
<td>commit-queue+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089">bug 170089</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=305523&action=diff" name="attach_305523" title="Patch">attachment 305523</a> <a href="attachment.cgi?id=305523&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=305523&action=review">https://bugs.webkit.org/attachment.cgi?id=305523&action=review</a>
<span class="quote">>>>> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2462
>>>> + }
>>>
>>> Looking the loadDouble code, we can see WTF_MIPS_ISA(1) guard.
>>> Isn't it required here?
>>
>> I think Yusuke is right. FPRegisterIDs refer to 64-bit registers. In
>> MIPS32/MIPS-II “ldc1” can be used to load a 32-bit value directly,
>> but in MIPS-I it is needed to use two “lwc1” instructions, one for
>> each 32-bit half of the 64-bit value.
>
> No, I don't think we need that guard. loadDouble/storeDouble use that because MIPS-I does not contain the ldc1 (resp. sdc1) instruction, and therefore two lwc1 (resp swc1) instructions are used instead for the MIPS-I version. In loadFloat/storeFloat, we do not use ldc1/sdc1, and all the instructions that we use are MIPS-I compatible AFAIK, so there's no need for an alternative version.
> You can see that the pre-existing loadFloat/storeFloat with a BaseIndex argument don't have such a guard either, for the same reasons.
>
> Another way to put it: the need for special cases for MIPS-I only exists when dealing with doubles. The fact of using an ImplicitAddress instead of a BaseIndex does not incur this need.
>
> Another debate is whether we still want to support MIPS-I, I don't know if there still are many devices using that where it makes sense to use webkit, though I could be wrong, because, hey, we have these guards in the code.</span >
Make sense.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>