<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling geolocation authorization requests"
href="https://bugs.webkit.org/show_bug.cgi?id=170362">bug 170362</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #306764 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling geolocation authorization requests"
href="https://bugs.webkit.org/show_bug.cgi?id=170362#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add SPI for handling geolocation authorization requests"
href="https://bugs.webkit.org/show_bug.cgi?id=170362">bug 170362</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=306764&action=diff" name="attach_306764" title="Patch v2.1">attachment 306764</a> <a href="attachment.cgi?id=306764&action=edit" title="Patch v2.1">[details]</a></span>
Patch v2.1
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=306764&action=review">https://bugs.webkit.org/attachment.cgi?id=306764&action=review</a>
LGTM except the memory leak.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:92
> + RetainPtr<id<_WKGeolocationCoreLocationProvider>> _coreLocationProvider;</span >
I'm not sure if the id is necessary here. If it is, we seem to have a space after id elsewhere in WebKit.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:269
> + _provider = [[WebGeolocationCoreLocationProvider alloc] initWithListener:self];</span >
We need an adoptNS or this is a memory leak.
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm:42
> +SOFT_LINK_FRAMEWORK(CoreLocation)
> +SOFT_LINK_CLASS(CoreLocation, CLLocation)</span >
Is there a reason we're soft linking?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>