<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Adopt AVKit name change from AVFunctionBar* to AVTouchBar*"
href="https://bugs.webkit.org/show_bug.cgi?id=170693#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Adopt AVKit name change from AVFunctionBar* to AVTouchBar*"
href="https://bugs.webkit.org/show_bug.cgi?id=170693">bug 170693</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to Tim Horton from <a href="show_bug.cgi?id=170693#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=306741&action=diff" name="attach_306741" title="Patch">attachment 306741</a> <a href="attachment.cgi?id=306741&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=306741&action=review">https://bugs.webkit.org/attachment.cgi?id=306741&action=review</a>
>
> > Source/WebCore/platform/spi/cocoa/AVKitSPI.h:161
> > +typedef AVTouchBarMediaSelectionOption WKAVTouchBarMediaSelectionOption;
>
> Though I think it was my suggestion to do the WK-, now I wonder if it would
> be better to just typedef to the new names on the old OS, and use the new
> names everywhere? We know they won't magically appear in the old SDK.</span >
Oh yeah, that's a pretty good idea. I'm going to attach a new patch that doesn't do that yet just to see if I can get the bots green.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>