<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add API to get available content extension identifiers in a WKContentExtensionStore"
href="https://bugs.webkit.org/show_bug.cgi?id=170093">bug 170093</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #305352 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add API to get available content extension identifiers in a WKContentExtensionStore"
href="https://bugs.webkit.org/show_bug.cgi?id=170093#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add API to get available content extension identifiers in a WKContentExtensionStore"
href="https://bugs.webkit.org/show_bug.cgi?id=170093">bug 170093</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=305352&action=diff" name="attach_305352" title="patch">attachment 305352</a> <a href="attachment.cgi?id=305352&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=305352&action=review">https://bugs.webkit.org/attachment.cgi?id=305352&action=review</a>
r=me
<span class="quote">> Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp:404
> + completionHandler(identifiers);</span >
I think you need to WTFMove(identifiers) again in this argument expression or you will copy the vector. (The capture expression creates an rvalue reference by WTFMove, but immediately assigns that reference to an lvalue named "identifiers".)
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm:115
> + NSMutableArray<NSString *> *nsIdentifiers = [NSMutableArray arrayWithCapacity:100];</span >
Why not use the capacity in identifiers?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>