<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Have parseRevisionProperty use default repo name as the buildbot key."
href="https://bugs.webkit.org/show_bug.cgi?id=170696">bug 170696</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #306749 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Have parseRevisionProperty use default repo name as the buildbot key."
href="https://bugs.webkit.org/show_bug.cgi?id=170696#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Have parseRevisionProperty use default repo name as the buildbot key."
href="https://bugs.webkit.org/show_bug.cgi?id=170696">bug 170696</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=306749&action=diff" name="attach_306749" title="Patch">attachment 306749</a> <a href="attachment.cgi?id=306749&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=306749&action=review">https://bugs.webkit.org/attachment.cgi?id=306749&action=review</a>
<span class="quote">> Tools/ChangeLog:9
> + buildobt data. That is no longer necessary as we can make a safe assumption</span >
buildobt => Buildbot
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:208
> + var key = repositoryName;</span >
Instead of default initializing these variables and then overwriting them for OpenSiurce I suggest that we leave them hninitialized here and remove the "else if" For Internal.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>