<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: WebSockets: frame context menu items should content sniff to be more relevant"
href="https://bugs.webkit.org/show_bug.cgi?id=170568#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: WebSockets: frame context menu items should content sniff to be more relevant"
href="https://bugs.webkit.org/show_bug.cgi?id=170568">bug 170568</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>(In reply to Brian Burg from <a href="show_bug.cgi?id=170568#c0">comment #0</a>)
<span class="quote">> Currently we have "Log Frame Text" and "Log Frame Value". The latter logs
> the frame as JSON, whether or not it actually is JSON.</span >
I'm having trouble understanding this. We do know it is actually JSON, we've done a JSON.parse() on the contents to prove it.
<span class="quote">> We should sniff the values prior to appending the menu items. If it is
> JSON, have "Log Frame as JSON" and "Log Frame as Text". If it's not
> JSON, then the option should be "Log Frame Value".</span >
My expectations are:
(1) if the frame is text => have a Log Text option
(2) if the text is JSON => have a Log Value option
which currently matches the code.
Is there a specific case where the context menus were confusing?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>