<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089">bug 170089</a>
from <span class="vcard"><a class="email" href="mailto:aperez@igalia.com" title="Adrian Perez <aperez@igalia.com>"> <span class="fn">Adrian Perez</span></a>
</span></b>
<pre>(In reply to Guillaume Emont from <a href="show_bug.cgi?id=170089#c5">comment #5</a>)
<span class="quote">> Another way to put it: the need for special cases for MIPS-I only exists
> when dealing with doubles. The fact of using an ImplicitAddress instead of a
> BaseIndex does not incur this need. </span >
Oh, I was assuming that loadFloat() would emit a load for a 64-bit value.
Thanks for clarifying.
Then you're right (and I should have checked the code before commenting)
and it's an r+me :-)
<span class="quote">> Another debate is whether we still want to support MIPS-I, I don't know if
> there still are many devices using that where it makes sense to use webkit,
> though I could be wrong, because, hey, we have these guards in the code.</span >
The cost of maintaining MIPS-I support is quite low:
~/devel/WebKit % rg -F 'WTF_MIPS_ISA(1)' Source | wc -l
8
There's only the code for emitting load/save of 64-bit floating point values
in “MacroAssemblerMIPS.h”, and two one-liners to insert “nop”-delays after
some load instructions.
It does not seem that it is much of a problem to keep the support around,
though it's difficult to gauge how often JSC ends up running on MIPS-I
hardware. As far as I know that would be only the original R2000/R3000
CPUs, and more recently clones (e.g. OpenCores has a synthetizable clean
room design) often used as microcontrollers — so I have no strong opinion
towards keeping the MIPS-I bits.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>