<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: WebSockets: frame context menu items should content sniff to be more relevant"
href="https://bugs.webkit.org/show_bug.cgi?id=170568">bug 170568</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>joepeck@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: WebSockets: frame context menu items should content sniff to be more relevant"
href="https://bugs.webkit.org/show_bug.cgi?id=170568#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: WebSockets: frame context menu items should content sniff to be more relevant"
href="https://bugs.webkit.org/show_bug.cgi?id=170568">bug 170568</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>(In reply to Nikita Vasilyev from <a href="show_bug.cgi?id=170568#c3">comment #3</a>)
<span class="quote">> (In reply to Brian Burg from <a href="show_bug.cgi?id=170568#c1">comment #1</a>)
> > Since this uses RemoteObject to get the data, this change may require to
> > sniff the content in the model side since we don't want to block showing the
> > context menu on a round trip to get the remote object.
>
> Are you suggesting to JSON.parse every message when it's added? If so, I'd
> have to test how much performance penalty it adds for big JSON messages.</span >
We already do this when the context menu is triggered.
See the discussion and patches on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Web Inspector: add context menu item to log content of WebSocket frame"
href="show_bug.cgi?id=169945">bug 169945</a>:
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Web Inspector: add context menu item to log content of WebSocket frame"
href="show_bug.cgi?id=169945">https://bugs.webkit.org/show_bug.cgi?id=169945</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>