<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MathML: Extra left space for arrows inside <mo>"
href="https://bugs.webkit.org/show_bug.cgi?id=170272#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MathML: Extra left space for arrows inside <mo>"
href="https://bugs.webkit.org/show_bug.cgi?id=170272">bug 170272</a>
from <span class="vcard"><a class="email" href="mailto:lambda@liu.ms" title="Minsheng Liu <lambda@liu.ms>"> <span class="fn">Minsheng Liu</span></a>
</span></b>
<pre>Thanks for the feedback. I will look at it when I have more time later this week.
However, I do have some question regarding the tests, as I am completely new to WebKit hacking. Hours ago, I run a WebKit test on my modified build. While there were many issues, none of them were related with MathML. I expect at least some diffs in MathML tests. Are MathML tests in LayoutTests/ automated or manual? What is the right way to see whether I have broken existing *MathML* code or not?
(In reply to Alejandro G. Castro from <a href="show_bug.cgi?id=170272#c6">comment #6</a>)
<span class="quote">> (In reply to Minsheng Liu from <a href="show_bug.cgi?id=170272#c4">comment #4</a>)
> > I believe I have found the issue, but since I am not familiar with the code,
> > I am not sure what is the right way to fix it. In RenderMathMLOpeartor.cpp,
> > line 290 - 311:
> >
> > > void RenderMathMLOperator::paint(PaintInfo& info, const LayoutPoint& paintOffset)
> > > {
> > > RenderMathMLToken::paint(info, paintOffset);
> > > if (!useMathOperator())
> > > return;
> > >
> > > LayoutPoint operatorTopLeft = paintOffset + location();
> > > operatorTopLeft.move(style().isLeftToRightDirection() ? leadingSpace() : trailingSpace(), 0);
> > >
> > > // Center horizontal operators.
> > > if (!isVertical())
> > > operatorTopLeft.move(-(m_mathOperator.width() - width()) / 2, 0);
> > >
>
> I also wonder why are we doing this part of the layout in the paint method,
> probably we should try to move to the layout if we don't find any real
> limitation. This could be also the problem, as you found leadingSpace is a
> calculation already centered and we are centering again in the paint. Maybe
> just try to move that to the layout and see if that is already done. As Fred
> said run the tests because there are a lot of cases to consider in this code.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>