<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351">bug 170351</a>
from <span class="vcard"><a class="email" href="mailto:iscaro@profusion.mobi" title="iscaro <iscaro@profusion.mobi>"> <span class="fn">iscaro</span></a>
</span></b>
<pre>Hello,
<span class="quote">> I think this is very roundabout. Introducing a setting that you have to hack
> into the .asm file with a dummy if statement is super dirty. We should have
> the offlineasm program know what platform it's on. That's better since
> we'll never have a fat binary that is both iOS and non-iOS-arm. As it stands
> the introduction of a new settings flag doubles the runtime of offlineasm
> for everyone.</span >
I'm sorry for this 'dirty' code Filip. I saw that there were already some pieces of code doing that (just like the armv7 if above PLATFORM_IOS) and then I though it was the right way to do. To be honest, I tried to add a command line option to offlineasm which flagged that the target was iOS. However, I could not find a easy way to do that.
<span class="quote">> Would it be enough for you to detect in arm.rb if you're running on Darwin?</span >
Yes, it would be enough. What do you think about adding the following constant at arm.rb?
IS_IOS = ((RUBY_PLATFORM =~ /darwin/i) != nil)
Sounds good?
Thanks.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>