<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebAssembly: Ref count Signature and SignatureInformation should not care about VM"
href="https://bugs.webkit.org/show_bug.cgi?id=170316#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebAssembly: Ref count Signature and SignatureInformation should not care about VM"
href="https://bugs.webkit.org/show_bug.cgi?id=170316">bug 170316</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=305943&action=diff" name="attach_305943" title="patch">attachment 305943</a> <a href="attachment.cgi?id=305943&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=305943&action=review">https://bugs.webkit.org/attachment.cgi?id=305943&action=review</a>
<span class="quote">>>> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:412
>>> +auto B3IRGenerator::addArguments(const RefPtr<Signature>& signature) -> PartialResult
>>
>> style: Revert this or use Signature& here. It's an anti-pattern to use a ref to a container class when the function isn't going hold any reference anyway.
>
> I don't agree. I made "const RefPtr<Signature>&" precisely because the function doesn't need to ref it.</span >
I misread your comment. Anyways, I still don't agree. We use this pattern all over the place in JSC.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>