<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351">bug 170351</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #305990 Flags</td>
<td>
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351">bug 170351</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=305990&action=diff" name="attach_305990" title="The patch">attachment 305990</a> <a href="attachment.cgi?id=305990&action=edit" title="The patch">[details]</a></span>
The patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=305990&action=review">https://bugs.webkit.org/attachment.cgi?id=305990&action=review</a>
I was wondering why this never posed a problem before for us before. I did a local build, and see that the compiled LowLevelInterpreter.o does emit blx instructions. However, in the llinked version of the code, the linker changed the blx into bl instructions. If the toolchain does not fix this for us, then this bug would have manifested.
Hence, r=me
<span class="quote">> Source/JavaScriptCore/ChangeLog:8
> + 'call' meta-instruction (which may be found in LowLevelInterperter.asm</span >
typo: /LowLevelInterperter.asm/LowLevelInterpreter.asm/
<span class="quote">> Source/JavaScriptCore/ChangeLog:16
> + This behaviour is unwanted, since the C++ code and the offlineasm code</span >
/offlineasm code/offlineasm generated code/</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>