<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a warning for unused link preloads."
href="https://bugs.webkit.org/show_bug.cgi?id=165670">bug 165670</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>youennf@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a warning for unused link preloads."
href="https://bugs.webkit.org/show_bug.cgi?id=165670#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a warning for unused link preloads."
href="https://bugs.webkit.org/show_bug.cgi?id=165670">bug 165670</a>
from <span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=165670#c24">comment #24</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=165670#c23">comment #23</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=304495&action=diff" name="attach_304495" title="Patch">attachment 304495</a> <a href="attachment.cgi?id=304495&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=304495&action=review">https://bugs.webkit.org/attachment.cgi?id=304495&action=review</a>
> >
> > > Source/WebCore/loader/cache/CachedResourceClient.h:48
> > > + virtual bool markAsReferenced() const { return true; }
> >
> > I'm not sure this is named correctly. shouldMarkAsReferenced?
>
> Yeah, I'll rename
>
> > Isn't there already a way to tell if a load is a preload?
>
> There is already a way to tell if a certain request is a preload request or
> a preloaded resource.
> However, a preloaded resource can be referenced (e.g. `<link rel=preload
> href=foo as=script><script src=foo>`).
> Current tracking if a resource is referenced is based on the addition of
> CachedResourceClients to it. So I figured it'd be cleanest to add that "is
> this referencing" info to the resource client.
>
> >
> > > LayoutTests/TestExpectations:1260
> > > +http/tests/preload/single_download_preload.html [ DumpJSConsoleLogInStdErr ]
> >
> > Does this make these tests not accidentally print out a warning message?
>
> Yeah
>
> > Is there no way to do this from within the test?
>
> Don't know. If there is, I'd be happy to switch to that method</span >
Hmm, the debug bot failure seems to indicate that it's not taking this directive into account. Is that a known issue? Is there a way to get around that?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>